fix: answer range format validation and error message in Numerical input#2426
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
core contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 94.71% 94.75% +0.04%
==========================================
Files 1202 1205 +3
Lines 26845 26950 +105
Branches 6023 5896 -127
==========================================
+ Hits 25425 25536 +111
- Misses 1350 1355 +5
+ Partials 70 59 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| if (rawUpperBound.includes('/')) { | ||
| if (!rawUpperBound) { | ||
| upperBoundInt = lowerBoundInt; |
There was a problem hiding this comment.
Not blocking, just adding context to the failing codecov check.
It seems codecov isn't considering this line as covered
There was a problem hiding this comment.
Thanks for notice, I have removed this line because it is no longer needed.
|
I think there is a bug with negative numbers. Negative numbers should be allowed, but it's showing them as an error: 
|
ihor-romaniuk
force-pushed
the
romaniuk/answer-range-validation
branch
from
cf8e336 to
9792794
Compare
|
@bradenmacdonald Thanks for your check. I have extended a regexp to allow negative numbers. |
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
I think there is one more issue?
| const [numerator, denominator] = lowerBoundFraction.split('/'); | ||
| const lowerBoundFloat = Number(numerator) / Number(denominator); | ||
| lowerBoundInt = lowerBoundFloat; | ||
| lowerBoundInt = Number(numerator) / Number(denominator); |
There was a problem hiding this comment.
Thanks! What about these fractional values like [1/2,3/4] ? They seem to be supported in the code, and on master they are working, but with this PR it rejects them as invalid.
There was a problem hiding this comment.
Sure, thanks. Also add support for fractions numbers.
|
There is another bug, but I think it's out of scope here:
|
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
If you'd like to submit another PR for the other bug ^ , I'll try to review+merge it quickly.
5 participants
Backport Pull Requests to frontend-lib-content-components: openedx-unsupported/frontend-lib-content-components#511
Description
These fixes enhance input range validation for numeric responses in OLX format.
The updated logic ensures that user responses follow a consistent, predictable format and that all invalid or ambiguous cases are correctly rejected.
Supported response formats
[1,10],(1,10),[-5,10],(-1.5,7.25)[1, 10],[ 1,10 ],[ 1 , 10 ],( -1 , 1 )[1.1,10.5],[-2.5,5][1/2,2],(1/4,3/4),[-3/2,-1/2]Invalid response examples
{1,10},(1,10],[1,10[1 10],(1,,10)(,10),(1,),[][1;10],[1.10],[--5,10],[1/10][10,1](min > max)Steps to reproduce
Actual result
Nothing happened, in console there's error
Note: the same when user print additional bracket
Expected result
Some validation should be for field or some error message for user should be shown
Before save:
After save:
Note
Old closed MR #1557